Jordan Rome
Jordan Rome
Looks good! One last thing (and maybe this needs to be a separate PR) but can we detect if users are setting an offset themselves or using a glob for...
Looks like maybe one of the new added tests needs to fixed for AOT or added to the skip list.
I think we might need a different syntax for the probes because not only do we not want the probe action to execute if the arch doesn't match but we...
> So, after putting more thought into this, I'm actually for reusing the existing concepts and just improving the bpftrace logic when it comes to predicates that can be resolved...
> Once the patch is released (should be in the next libbpf version 1.5.0), do we want bpftrace to require the latest libbpf (which many distros do not package)? Is...
Love to see all this deleted code. Nice job, @viktormalik! All looks surprisingly straightforward. Just curious, it seems like multiple subprogs now work with this, which is AWESOME! Did you...
I agree with @viktormalik. Going to close this for now. Please feel free to re-open if this is still desired.
Maybe a temporary solution for this could be to assume the user is utilizing the new delete API if the first argument is a reference to a map that has...
> I'd rather we just fix it properly in all situations, and the easiest way to do that is (IMO) to fully remove the multi-delete syntax. It's pretty new (only...
@danobi - You can delete scalar maps. It's equivalent to calling `clear`. > Can we warn in that case that the semantics have changed? If we're removing the ability to...