Jon Rohan comments

Results 42 comments of


                                            Jon Rohan

Adding color themes to lookbook

I'm not sure this is the correct approach, closing for now

Using border-dashed CSS class raises warning in development

👋🏻 Sorry for the late reply, I think you can use `border: :dashed` here to get the class you want. I'm going to investigate why it's not documented.

feat: create github deployment

@amondnet 👋🏻 This is great, any chance you could merge it in soon?

Component theme switcher

👋🏻 Dropping by on this to hopefully had some insight on where we are with support for it and what would be useful from the library. Maybe a more general...

migrate Primer::Image to Primer::Alpha::Image

Closing in favor of https://github.com/primer/view_components/pull/1527

The Edit the page on GitHub link for view-components doesn't link to the right place

@tallys

The Edit the page on GitHub link for view-components doesn't link to the right place

I'm closing this, as it'll be addressed in a new docs system we're working on.

Remediate remaining CSS gaps

We're moving in this direction, but this Issue doesn't accurately describe the problem

[Feedback] npm package contains duplicate icon data

I think this is still an issue. I believe both data sources are in use, so we'd need to investigate which one we can remove and update any libraries using...

Bump flat and mocha

I'm gonna close