octicons icon indicating copy to clipboard operation
octicons copied to clipboard

Published 20 hours ago • verified publisher icon primer

[Feedback] npm package contains duplicate icon data

Open xt0rted opened this issue 3 years ago • 13 comments

Describe the topic

I just installed v16.1.1 of @primer/octicons and noticed the svg folder and data.json file are duplicated in the package. I don't think this is intended and it's doubling the size of the package.

image

xt0rted avatar Nov 20 '21 10:11 xt0rted

Hi @xt0rted, thanks for letting us know! We'll take a look at this once we get some open bandwidth.

ashygee avatar Nov 22 '21 14:11 ashygee

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar May 21 '22 15:05 github-actions[bot]

Still an issue in 17.2.0

xt0rted avatar May 21 '22 17:05 xt0rted

@jonrohan is this something you might be able to squeeze in this quarter?

lesliecdubs avatar Aug 22 '22 15:08 lesliecdubs

Following up, @jonrohan is this still an issue or can we close this?

tallys avatar Jan 05 '23 17:01 tallys

I think this is still an issue. I believe both data sources are in use, so we'd need to investigate which one we can remove and update any libraries using them.

jonrohan avatar Jan 05 '23 17:01 jonrohan

Hey @JoshBowdenConcepts, this might be a good one to pick up - thoughts?

tallys avatar Jan 31 '23 20:01 tallys

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Jul 30 '23 21:07 github-actions[bot]

Thank you for raising this issue, it is a known error and is in our backlog.

tallys avatar Aug 07 '23 15:08 tallys

Would you accept a PR? Sounds like a quick change. This bug doubles the size of the package

https://packagephobia.com/result?p=@primer/[email protected]

fregante avatar Dec 15 '23 11:12 fregante

Hi @fregante, thanks for the offer. Yes, we would gladly accept a PR for this change!

lesliecdubs avatar Dec 19 '23 16:12 lesliecdubs

@lesliecdubs done

fregante avatar Dec 20 '23 03:12 fregante

Thanks @fregante! ✨ We might be a little slower than usual with PR review due to the holiday season, but we should be able to get to it in the new year. Thanks for contibuting!

lesliecdubs avatar Dec 27 '23 04:12 lesliecdubs

This can be closed once https://github.com/primer/octicons/pull/1010 is published to npm. We should see the halving of the package here: https://packagephobia.com/result?p=@primer/octicons

fregante avatar Mar 13 '24 05:03 fregante

Just wanted to confirm that I don't see this anymore in v19.9.0. Going to close this out as I believe it's been addressed, feel free to leave a comment if I'm getting something wrong here!

joshblack avatar Mar 27 '24 16:03 joshblack

Indeed in my link you can see the package going from 2.16 to 1.08, exactly half

fregante avatar Mar 27 '24 16:03 fregante