Jon Koops
Jon Koops
@tlabaj could you mark this as a breaking change?
I'm a big fan of Styled Components as it helps keep the styling with the component instead of using complicated and error prone selectors. SCSS only seems to make things...
It also removes the need for another dependency, which is always good. As long as we can explicitly import the styles instead of manually matching class names and selectors I...
Note that this would only affect our styling and not the styling we're importing from PatternFly. I think we should proceed with CSS modules rather than Styled Components as we...
@edewit @agagancarczyk @ssilvert can we commit to the above as a team?
> Are we using custom styling in places where we could accomplish the same thing with PatternFly's CSS? Yes, in a lot of cases I think we can remove our...
@edewit the tests seem to keep failing, can you take a look?
@jruhe-adesso could you file that as a separate issue? I'd like to avoid cluttering the discussion.
Yeah, I am still seeing this is an issue. Re-opening.