patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Ship packages as ESM only

Open jonkoops opened this issue 2 years ago • 1 comments

Is this a new component or an extension of an existing one? This applies to all packages in the PatternFly React repository.

Describe the feature Instead of shipping PatternFly React packages with a bunch of different module systems (UMD, CommonJS, etc). All packages would be shipped only in the standardized ECMAScript module format.

jonkoops avatar Sep 21 '22 10:09 jonkoops

@tlabaj could you mark this as a breaking change?

jonkoops avatar Sep 21 '22 10:09 jonkoops

Moving to backlog because we plan to continue supporting CJS and UMD in the near future due to product requirements.

wise-king-sullyman avatar Nov 07 '22 18:11 wise-king-sullyman

@wise-king-sullyman could you provide some insights into these requirements?

jonkoops avatar Nov 10 '22 18:11 jonkoops

@jonkoops sorry for the delayed response. I don’t know the specifics off the top of my head, but we were informed that several products are currently reliant on the non-esm modules and would likely not be able to switch to using the esm modules in the near term.

We will be bringing up this discussion with product teams at our community meeting next week to gather more information.

wise-king-sullyman avatar Dec 08 '22 18:12 wise-king-sullyman

I'd be really curious about that, considering that pretty much all front-end tooling is heavily based on ESM. The only one I can think of would perhaps be Jest (since it runs in Node.js), but I almost can't imagine folks would be running that without a pre-processor.

So yeah, just wondering what the exact use-cases of those teams are. Perhaps they believe they really need other distributions, and perhaps they do, perhaps they don't.

jonkoops avatar Dec 08 '22 22:12 jonkoops

@wise-king-sullyman any news on this matter?

jonkoops avatar Jan 18 '23 15:01 jonkoops

@jonkoops no real updates yet, but I'm currently trying to figure out how we figure out who all is reliant on the CJS modules. Will update when able.

wise-king-sullyman avatar Jan 24 '23 15:01 wise-king-sullyman