Jon Gjengset

Are there tests in the original PR too? If there are, would you mind porting them over? Otherwise, just copy an existing basic `flamegraph` test, run it with `total`, and...

No rush — take whatever time you need :) That's exciting! Yes, it looks all good. You _can_ tidy up your commit history if you wish, but otherwise I'll just...

Yeah, what you'd want to do is implement a "collapser" for the xctrace output format (see the [existing collapsers](https://github.com/jonhoo/inferno/tree/master/src/collapse)). Once that's in place, you should be able to take an...

Hmm, interesting. It's not clear that there's quite enough information in there to construct a flamegraph since it chops off the other frames in the backtrace (or at least it...

Hi there! Ideally, this should all be documented on https://docs.rs/inferno/latest/inferno/flamegraph/fn.from_lines.html, but at the moment it is a little thin. There's also some documentation of the format in the original `flamegraph.pl`:...

Ah, yes, so, the effect of `--flamechart` is really to just not re-sort the input. The rest of the plotting code remains the same, which includes walking up and down...

I think you're completely right that this is confusing, and I like your proposal to make it multipliers instead (and consistent (inverted?) across directions). Totally fine with removing the current...

Hmm, interesting. Could you post the output of `perf script` somewhere if it's not too large?

Hmm, this _looks_ like you just have a single sample, in which case all the stack frames should be the same size?

That I don't know -- seems like it is probably an issue with how `cargo flamegraph` collects samples.