add --total option. See https://github.com/brendangregg/FlameGraph/pu…

[smitty3268]

add --total option for generating the flame graph. see https://github.com/brendangregg/FlameGraph/pull/14 and https://github.com/jonhoo/inferno/issues/17.

The use case for this option is comparing multiple perf runs directly against one another. Specifying the # of samples to use for the total width means the individual rectangles in each graph can be directly compared to each other rather than being resized differently if one run finished more quickly than another.

[jonhoo]

This looks great, though it appears that it doesn't fully compile?

[codecov[bot]]

Codecov Report

Merging #154 into master will decrease coverage by 0.13%. The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage    88.4%   88.26%   -0.14%     
==========================================
  Files          16       16              
  Lines        2200     2208       +8     
==========================================
+ Hits         1945     1949       +4     
- Misses        255      259       +4

Impacted Files	Coverage Δ
src/flamegraph/mod.rs	93.9% <22.22%> (-2.04%)	:arrow_down:
src/collapse/common.rs	60.92% <0%> (+0.33%)	:arrow_up:
src/flamegraph/color/palette_map.rs	92.92% <0%> (+0.88%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef496bf...14f4168. Read the comment docs.

[jonhoo]

Are there tests in the original PR too? If there are, would you mind porting them over? Otherwise, just copy an existing basic flamegraph test, run it with total, and commit the result.

[smitty3268]

I'll take a look at adding a test, but it may be a few days before I have a chance.

This is my first pull request on github, does everything here look ok? In particular, do I need to clean up the commits in my fork, or is ok to just have them all there separately like they are now?

[jonhoo]

No rush — take whatever time you need :)

That's exciting! Yes, it looks all good. You can tidy up your commit history if you wish, but otherwise I'll just squash them all into one commit before merging. It's probably not worth doing a lot of commit tweaking for a change this small, and individual commits are easier to review anyway!