Jongyoul Lee

Results 136 comments of Jongyoul Lee

It looks like we need to keep on eyes. Can someone help to review it?

Yes, as I remember, we already talked about this issue before. I also would like to prepare for Windows CI but we might not have much knowledge for it. What...

@zjffdu I think this issue introduces more potential problems but it's not related to this PR directly. How about merging it first? It looks like a useful log. WDYT?

I agree with @zjffdu. AFAIK, we already have a modal for some other reasons. Can we reuse them for this issue?

LGTM, @prabhjyotsingh Could you please verify it finally? I'll merge it there's no more discussion.

@sanjaydasgupta I'm not sure your option is better than noticing with a release message. Generally, we add breaking change message like this kind of modification. Personally, I like to remove...

I agree that the hook up `ui-grid` from `old button` makes sense. @Tagar @sanjaydasgupta

@sanjaydasgupta As a longterm plan, I like to remove old button as it's not maintained at all for now. But discussing those kinds of issues in a PR is not...