zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-5632] zeppelin-zengine: Skip load notebook when it is damaged.

Open woowahan-jaehoon opened this issue 3 years ago • 7 comments

What is this PR for?

Skip load notebook when it is damaged.

When I upgraded zeppelin 0.7 to 0.9 and I converted notebook, some notebooks are damaged. Caused damaged notebooks, zeppelin cannot start completely. But damaged notebooks can find very very hard.

What type of PR is it?

[Bug Fix]

Todos

  • Nothing

What is the Jira issue?

  • https://issues.apache.org/jira/browse/ZEPPELIN-5632

How should this be tested?

  • Maybe create damaged notebook and start zeppelin...?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
    • No
  • Is there breaking changes for older versions?
    • No
  • Does this needs documentation?
    • No

woowahan-jaehoon avatar Jan 13 '22 23:01 woowahan-jaehoon

ping @woowahan-jaehoon

zjffdu avatar Feb 09 '22 04:02 zjffdu

@woowahan-jaehoon Could you rebase it?

zjffdu avatar Feb 23 '22 10:02 zjffdu

@woowahan-jaehoon Could you rebase it?

I did.

woowahan-jaehoon avatar Mar 01 '22 07:03 woowahan-jaehoon

Thanks @woowahan-jaehoon , could you take a look at this comment?https://github.com/apache/zeppelin/pull/4288#discussion_r793226376

zjffdu avatar Mar 01 '22 07:03 zjffdu

@woowahan-jaehoon Can you add unit test for it?

zjffdu avatar Mar 14 '22 08:03 zjffdu

@zjffdu I think this issue introduces more potential problems but it's not related to this PR directly. How about merging it first? It looks like a useful log. WDYT?

jongyoul avatar Apr 20 '22 11:04 jongyoul