Jongyoul Lee

Results 136 comments of Jongyoul Lee

> What do you think about including hk2 on in the zeppelin-zengine module? I, totally, agree with you. It would be better to adopt it but to do it, we...

Basically, I think it would be better to perform validation logic before starting the server. By doing it, you could avoid multithreading issues that you mentioned in my PR. But,...

I thought we should consider the case where we don't use Shiro. That's the only reason why I moved that logic into the constructor of `SecurityService`

Thanks. Now, you can validate `shiro.ini` before injecting it into Jetty. I think we could add your logic inside `public static void main` directly. But you might consider the case...

Thanks. I missed it. Then we could check if some objects are inherited from `AuthorizingRealm` or not, correct? 2019년 10월 31일 (목) 12:20, Prabhjyot 님이 작성: > *@prabhjyotsingh* commented on...

Got it. It looks more clear way to check it. 2019년 10월 31일 (목) 12:53, Prabhjyot 님이 작성: > Yes, I think that should do it. > > — >...

But you can check if classes are children of `AuthorizingRealm` or not by many ways including reflection. 2019년 10월 31일 (목) 13:26, bhavikpatel9977 님이 작성: > Thanks. I missed it....

You can use a system classloader to get the list of realms. https://github.com/apache/shiro/blob/master/core/src/main/java/org/apache/shiro/config/IniSecurityManagerFactory.java#L193-L222

It looks quite a useful approach but I believe that you'd better make another notebook repo to keep current one and to adopt your own git repository. :-)