Jonathan Chang

Results 14 comments of Jonathan Chang

I'm trying to get this software into Homebrew. While our binary builds use `-march=core2` and will thus be unaffected, builds from source always use `-march=native` and thus break compilation.

The `xz` formula provides `liblzma`, so adding a dependency on that might help with the linkage

> Replace #{bin} with #{opt_bin} in tests, which doesn't rely on linkage of formual. We don't need to make this change. All changes from python -> python3.10 need revision bumps....

> Re opt_bin, it's indeed not necessary, though it's considered "good practice" (at least by the maintainers of homebrew-core). So I'll leave that in, unless you prefer I take it...

I've started CI checks on this. Note that you could probably just submit this to homebrew/core instead, as long as you provide a better test in the `test do` block.

Try `fails_with gcc: "5"` for Linux.

> Not sure what's the problem since I can build it without brew just using `make prod` and there are no errors. You're likely using a different compiler from your...

Yes, you'll need to add a `fails_with` for gcc 11. I also want to reiterate that you should submit this to https://github.com/homebrew/homebrew-core, since the CI resources there are better (including...

Looks like there are 291 formula that still use GOPATH. * [x] acmetool * [ ] ahoy * [x] akamai * [x] algernon * [x] aliyun-cli * [x] alp *...

It looks like [Debian sets `-trimpath` but doesn't strip binaries with `-s -w`](https://salsa.debian.org/go-team/packages/dh-golang/blob/04ec6d4878296ede1203e5f87f7f955492a11c50/lib/Debian/Debhelper/Buildsystem/golang.pm#L539-540). Would it be useful to add something like `std_go_args` (like we have for CMake builds)?