homebrew-bio
homebrew-bio copied to clipboard
nextclade 1.2.3 (new formula)
- [x] Have you followed the guidelines for contributing?
- [x] Have you checked that there aren't other open pull requests for the same formula update/change?
- [x] Have you built your formula locally with
brew install --build-from-source FORMULA
, whereFORMULA
is the name of the formula you're submitting? - [x] Does your build pass
brew audit --strict FORMULA
(after doingbrew install FORMULA
)?
This is my first foray into packaging with brew. Feedback welcome!
The CI error /__w/homebrew-bio/homebrew-bio/.git: Permission denied
is unrelated to your PR. I'll take a look at it just as soon as I can find some time. Thank you for your patience.
Thanks @sjackman! I figured out myself that this probably wasn't my PR and opened this issue for the root error: https://github.com/brewsci/homebrew-bio/issues/1395
@corneliusroemer Can you rebase this on the current develop?
@eseiler Done! Someone needs to approve running workflows though, unfortunately. Maybe @sjackman @YoshitakaMo @jonchang @zbeekman? Not sure who has the rights.
I've started CI checks on this. Note that you could probably just submit this to homebrew/core instead, as long as you provide a better test in the test do
block.
Try fails_with gcc: "5"
for Linux.
When I try to build it locally in an Ubuntu docker image using brew install --build-from-source --verbose --debug nextclade.rb
I get the following error:
/home/linuxbrew/.linuxbrew/Cellar/gcc/11.2.0/lib/gcc/11/gcc/x86_64-pc-linux-gnu/11.2.0/include/waitpkgintrin.h:53:1: error: inlining failed in call to 'always_inline' 'unsigned char _tpause(unsigned int, long long unsigned int)': target specific option mismatch
53 | _tpause (unsigned int __A, unsigned long long __B)
| ^~~~~~~
Not sure what's the problem since I can build it without brew just using make prod
and there are no errors.
Any ideas?
Not sure what's the problem since I can build it without brew just using
make prod
and there are no errors.
You're likely using a different compiler from your host environment than brew's compiler.
https://github.com/oneapi-src/oneTBB/issues/370
It is likely an issue in this dependency when compiling with gcc 11.
Thanks! I didn't find that bug. So I would have to tell brew that all but gcc 9 works - or at least that gcc@11 doesn't.
Yes, you'll need to add a fails_with
for gcc 11.
I also want to reiterate that you should submit this to https://github.com/homebrew/homebrew-core, since the CI resources there are better (including for ARM macOS) and that repository gets more visibility than this one.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.