Jonathan Binney

Results 121 comments of Jonathan Binney
trafficstars

@v4hn thanks for describing in detail how this happens! This should have been happening for quite a while, right? Did this just start happening on PR2s? Since renaming filters now...

One possible fix: we could error out in the case that multiple plugins contain the filter name from the yaml. I suppose that would only break robots that already have...

Also, what version of ROS are PR2s running these days? Is it a version still built by the buildfarm?

Since the plugin finding code is in the filters package, I've created an issue there as well: https://github.com/ros/filters/issues/14

Filter finding in the filters package has now been updated to require the package name and exact filter name. When the PR2s are updated to Lunar, there will at least...

@vandanamandlik I think most of the comments on your other PR will transfer over to this one. Once we get that PR merged, I'll do a quick pass over this...

Not sure - if you haven't already, I'd suggest adding an issue on the ROS2 sensor_msgs package, since that is where it would go.

It would be good to keep support for both. It looks like ROS2 still has a PointCloud message: https://github.com/ros2/common_interfaces/tree/master/sensor_msgs/msg The PointCloud message is simpler to use for people who aren't...

That should be a separate thread - filters is used in lots of places other than laser_assembler.

This fell off of my radar. I'll take a look later this week.