Jonathan Barrow

Results 432 comments of Jonathan Barrow

Keeping a reference to `pokemon_species` seems fine imo, since "species" (at least in my interpretation) refers to the baseline default variation of a Pokemon, and in most cases this is...

A few follow up questions actually: 1. I just saw https://github.com/PokeAPI/pokeapi/issues/326, which seems to imply this data came from Veekun? Is this true? The data does seem to line up,...

I started looking into this again, it turns out one of the issues is that the color data from Veekun is just out of date? I checked the Veekun repo...

I forgot I made this issue until now. For those interested, I stumbled upon this on Reddit which looks promising https://github.com/seydx/node-av

No, it's little-endian mode that has the issue. Here is another example: ```js const { BitStream } = require('bit-buffer'); const buffer1 = Buffer.alloc(8); const buffer2 = Buffer.alloc(8); buffer1.writeDoubleLE(1.0, 0); buffer2.writeDoubleBE(1.0,...

I'm running this on my brand new Apple Silicon 2024 Mac Mini, which is little-endian, and I have not had any other issues with endianness in any other tools/libraries. I'm...

The tests all pass in the latest commit, but copying my repro to use said latest commit still fails to return the expected value. It has the same behavior as...

I've double checked the tests and despite the fact that they pass, the tests clearly have some issues. I've only checked the tests relevant to float64 but I suspect other...

Sounds good 👍 sorry if my asking sounded accusatory, it wasn't meant to be. I was just trying to get on the same page and confirm whether or not we're...

Confirmed that the latest commit does in fact fix things 👍 my test now shows the expected values, thank you very much for taking the time to fix this I...