Jonathan Barrow

Results 432 comments of Jonathan Barrow

@ashquarky @DaniElectra I've made it so that the proxy handling is now modular like we have for the encryption/compression implementations, as well as added 2 more protocol headers I don't...

Your proposals sound logical to me 1. Having an event system like you suggested is already somewhat being used in the common protocols lib, allowing for some RMC methods to...

> since the network got shut down From what we've seen over at Pretendo the Mii images endpoint is the only one which was actively taken down. Every other endpoint...

Correct, there are

> IMO I prefer using Go constants over maps for these magic numbers, since it allows for reading the underlying value directly on IDE and is in line with making...

@DaniElectra I did some playing around with some ideas for notifications, how does this look? ```go package main import "fmt" type NotificationEvents uint32 type subType uint32 // Exists strictly to...

@DaniElectra I've updated the return type to just be `types.UInt32` so it can be used directly on the struct it's intended for I've also pushed the first test of setting...

> > Maybe we should consider moving all simple fields to doing this, as it would avoid extra function hops and stuff > > By this you mean updating _every_...

@DaniElectra In `MatchmakeSessionSearchCriteria`, the `m_MatchmakeSystemType` field is handled as a string for some reason but the value is a normal integer enum. Should we change the type of `MatchmakeSessionSearchCriteria.MatchmakeSystemType` from...