Jonathan Barrow

> > In `MatchmakeSessionSearchCriteria`, the `m_MatchmakeSystemType` field is handled as a string for some reason but the value is a normal integer enum > > That's because it _is_ a...

> Also important note before we forget, we don't want to add validation checks for _every_ field. For example, CTGP-7 modifies the `m_MatchmakeSystemType` field (not the `m_GameMode`) on the `MatchmakeSession`...

(rebased the branch with the latest changes)

I believe this is ready for review now. I don't THINK I missed anything? All the protocols which have known constants should have them now, I think, as well as...

Actually I lied, I missed the Nintendo variant of the notifications protocol. How do we want to handle that? We have no known names for any of those constants, just...

> You mention day of the week/month, does this mean that these two cases are represented under the same field. Correct. Depending on the reset mode used, the `resetDay` value...

Actually maybe this isn't ready for review yet? I just double checked and so far only the following protocols have had constants added to them: - DataStore - MatchMaking -...

> I have gone through every single missing protocol available here (including non-NEX) listing some constants that could be added (those with question marks mean I'm not fully certain about...

UTC offsets themselves are static. They do not take DST into account because that is a local thing, and not everywhere recognizes it. Even in countries like the United States,...

To copy-paste my thoughts from Discord about the first screenshot: > Out of the 3 in this mock I also like both 2 and 3, but for different reasons >...