Jonas Nick
Jonas Nick
As I mentioned in the linked issue, I don't think this is a great idea. The tests have been written with a higher test iterations in mind. Lowering the test...
> Maybe a cleaner approach would be to reorganize headers such that most functions are in some header like secp256k1_main.h [...] I really like this idea. On the other hand,...
Interestingly the MuSig2 PR [fails with a segfault in the tests](https://github.com/bitcoin-core/secp256k1/actions/runs/8341073862/job/22827371569?pr=1479) and not in `./configure` like the signed-digit multicomb PR. I tried reproducing this locally using our docker file but...
> Can you try setting the additional sanitizer env variables that we set in the CI config? Good point. Still 0 crashes in 10 runs of ``` UBSAN_OPTIONS="print_stacktrace=1:halt_on_error=1" ASAN_OPTIONS="strict_string_checks=1:detect_stack_use_after_return=1:detect_leaks=1" LSAN_OPTIONS="use_unaligned=1"...
I can reproduce this now after looking into the bug reports. Need to set *both* ``` vm.mmap_rnd_bits = 32 vm.mmap_rnd_compat_bits = 16 ``` on the host for the crashes to...
> The second commit drops redundant "-1". You mean "== 1"?
@sipa said the following in the discussion: > < sipa> i don't think that running at more than 1 has ever actually contributed to a bug being found :p I...
Should have spelled this out more clearly: I have found bugs during development in code that was only correct if the Y coordinates of random group elements had a specific...
See also https://github.com/bitcoin-core/secp256k1/issues/1036
> The fact that the scratch space API forces us to write code which has predictable (and settable) memory usage, is both very useful (but only to some users) and...