Jonas Nick

Results 176 comments of Jonas Nick

@real-or-random and I have been brainstorming about the potential structure of the frost module's DKG, as well as what a potential bip-frost's DKG section might look like. We've consolidated our...

PR #216 contains two commits that fix compilation and tests.

I think you already did these changes, but, for reference, I made a checklist for rebasing https://github.com/BlockstreamResearch/secp256k1-zkp/discussions/266.

> Is there anything which has to be done to get this merged? @dr-orlovsky Yes, this needs a lot more review and polishing. As far as I know, no one...

The only two reasons I can come up with to have a `secp256k1_bppp_generators` object in the API are: 1. Avoid hard coding too many generators in the source code. For...

We've just merged https://github.com/BlockstreamResearch/secp256k1-zkp/pull/270 which means that this PR can be rebased to fix CI. Note that rebasing may require some additional changes that are documented in https://github.com/BlockstreamResearch/secp256k1-zkp/discussions/271. Let me...

> Hi @Tibo-lg , we expect users to call schnorr_adaptor_extract (was extract_t) before schnorr_adaptor_extract_sec (was schnorr_adaptor_extract_adaptor) so in this way the adaptor signature passed to 'extract_sec' is valid and would...

Here's my suggestion for a module level documentation (to be put at the top of include/secp256k1_schnorr_adaptor.h): ```C /** This module provides an experimental implementation of a Schnorr adaptor * signature...

The MuSig implementation in libsecp256k1-zkp has significantly changed while it was updated to the BIP version 1. Therefore, we should update the libsecp256k1-zkp version we use here.

Sorry this was automaticaly closed. PR needs to be reopened against the `master` branch.