Jonas Haag comments

Results 800 comments of


                                            Jonas Haag

add 'hide-invalid-repositories' option

Sorry, maybe wasn't clear enough – we can change behaviour only when `--hide-invalid-repos` is given, otherwise we're breaking backwards compat.

add 'hide-invalid-repositories' option

Yes, let's do the check later, for example in `main` where we do the other checks.

load line number of the tag in the tagsfile

Sounds reasonable. I wonder why it worked for me without the `-n` option?

Allow including images with relative paths in rendered pages (e.g. markdown)

I agree that we should fix this and I'm happy with both ways, but strong preference for 1.) because it is much simpler (though maybe not easier to implement)

Allow including images with relative paths in rendered pages (e.g. markdown)

> but I suspect most users would prefer a "smarter" solution that doesn't require they add querystrings to their image links. Indeed 8-)

Add signature snapshot

Can you explain what it is? I don’t think I have ever seen or used this feature

Add signature snapshot

Aha! Sounds like a useful feature, although I haven't seen it used anywhere yet. Happy to review a PR :)

OOM error on small repo when cloning/pull

Can you share the repo?

OOM error on small repo when cloning/pull

Maybe you can send the private repo via email so I can check it out

OOM error on small repo when cloning/pull

Thanks, will have a look tomorrow.