Jonas Haag

Results 800 comments of Jonas Haag

Love it! I think it's worth switching to this. Is it identical to the GitLab URL scheme? I think redirects are sufficient for backwards compatibility. We definitely need to redirect...

@s-ol: I'll happily merge this if it has working tests. Not saying you need to fix them, but it can very well be that nobody else will step forward for...

I spent some time updating the tests (and fixing them, mostly not your fault). Open problems: - `ChainedApps` is broken (`_cv_app` is undefined) - SmartHTTP seems to be broken (`/git-receive-pack`...

I’m sorry, I think I didn’t respond here because the tests fail and I wanted to wait for you to fix them before reviewing the PR

Review feedback: please add the new option at the end of the keyword arguments. Also I think it’s more obvious to only look at the hide flag where the invalid...

Thanks a lot, please move the new setting to very end so as to make the changes backwards compatible. Also what do you think about adding a "N invalid repositories...

I just tried this, but when I start `klaus --hide-invalid-repos some_invalid_repo`, I still get `klaus: error: argument DIR: 'some_invalid_repo': Not a Git repository`. I was expecting the option to ignore...

But how do you pass a folder on the command line?

But then the command line flag does not make a difference, does it?

I think it would be fine to have it disable the type check.