Jonas Finnemann Jensen

Results 459 comments of Jonas Finnemann Jensen

This is breaking, I'd suggest making a different better retry package :)

What is the expected behavior here? Documentation says this follows rules applied for [GFM sanitization](https://github.com/jch/html-pipeline/blob/master/lib/html/pipeline/sanitization_filter.rb). This doesn't allow the `` tag. I think we could be open to extending `sanitizeHtml`...

Uh, yeah, I think this could be a cool feature. Maybe we can just make it static function like: `Router.inspect(myRouter) -> Iterable` (or something like that). This would make even...

I think it's technically possible by simply return `null` from an `.all(` handler, example: ```dart router.all('/', (Request request) { // Do something here.... return null; }); router.get(....); ``` Maybe we...

@Kleak, another option is to leave middleware to [`shelf.Pipeline`](https://pub.dev/documentation/shelf/latest/shelf/Pipeline-class.html), see [shelf middleware docs](https://pub.dev/packages/shelf#handlers-and-middleware). Looking at: https://pub.dev/documentation/shelf/latest/shelf/Pipeline-class.html That might be a fine solution for middleware.. Mostly, you'll want middleware to wrap...

> If I want to use a middleware only on specific route I have to wrap it in a Router. For example a middleware that check if the user is...

If someone wants to draft a design and implement this, I'll be happy to help with reviews.

@Kleak, yes, that's the thinking.. So the code-generator would be aware of annotations that implement `MiddlewareAnnotation`, instantiate them, and call the `wrapHandler` method, instead of calling the actual handler. I'm...

Ah, yes, `myHandler(shelf.Request, String)` has a signature that depends on the number of variables in the route.. I doubt we can expose that in `wrapHandler`. But I see no reason...

> in shelf_router here a route entry can have a middleware but we can’t add it from here ah, I had completely forgotten about that. Hmm, I don't think I...