Jonas Finnemann Jensen comments

Results 459 comments of


                                            Jonas Finnemann Jensen

HttpDuplex.end() breaks output

@johnyDays, I experienced other issues with my fix. I suspect the best solution is to send the `Upgrade: tcp` headers as expected by docker.

string slicing should be encoding aware, use characters not bytes for offsets

Oh, I thought python did uft8, but Unicode is perfect... Anyways, yeah should operate on Unicode strings.. in Python that's just converting to Unicode strings... But how do you do...

string slicing should be encoding aware, use characters not bytes for offsets

I see @djmitche self-assigned, but I'm sure you're welcome to chip in... I'm guessing that fixing the `len()` function to return number of characters rather than bytes would be a...

string slicing should be encoding aware, use characters not bytes for offsets

@prachi, if this is an issue unrelated to go, file a separate issue and flag me... Probably you need to configure you golang install... And checkout on you go path......

string slicing should be encoding aware, use characters not bytes for offsets

Since you're new to golang I have to ask if you checkout the code in you `$GOPATH/src/github.com/taskcluster/json-e/` ? And have env vars `GOPATH` and `GOROOT` setup correctly? From you log...

Build a sandboxed rendering mode for node (extra security)

That's a fair point, maybe it's should be a separate npm module called `json-e-sandbox` or something..

Proposal: Remove `store.Create`, always return empty document from `store.Fetch`

Also if we do this, perhaps `store.Fetch` and `store.Store` should be renamed, get/set, and operate on `[]byte, so that any future model that does more fancy things can use the...

Proposal: Remove `store.Create`, always return empty document from `store.Fetch`

Not sure if it would be feasible, but adding: `RegisterHandlers(register register.PubPrivEndpointRegister) error` Would also be nice, notably because different storage engines supports different ways of listing/search/finding documents.

leaps loads documents twice (on first load)

Also, leaps seems to fetch the document every `flush_period_ms` regardless of whether or not there is any changes to the document. This is a problem, if we have a lot...

leaps loads documents twice (on first load)

I suspect it's `NewBinder` followed by `Subcribe` both of which does a `flush()`. Since we don't keep the document in memory, I'm not sure how to fix this... Maybe `NewBinder`...