Jonas Finnemann Jensen
Jonas Finnemann Jensen
Hmm, I can't reproduce this... in this repository... But it's definitely an issue in `dart-services`... However, if I remove `shelf_router_generator` from dependencies and add `json_serializable` I get the same issue....
I believe this has been resolved :)
If someone wants to work on this I'm happy to review PRs, just make sure the CC @jonasfj on PRs. Maybe it even makes sense for dart-neats to contain a...
lol, I just saw the old comment in https://github.com/google/dart-neats/issues/101#issuecomment-789717870 :rofl: hmm, ...maybe, I'm should be more open to signatures like: * `bool allowTag(String tag)`, and, * `bool allowAttribute(String tag, String...
The documentation of [`Router`](https://pub.dartlang.org/documentation/shelf_router/latest/shelf_router/Router-class.html) says: > If multiple routes match the same request, the handler for the first route is called. If the handler returns null the next matching handler...
I think we should either: A) Give an example of how to do `Cascade`-like things with `Router`, or, B) Make `Router.handler` default to returning `404`.
IMO, it would be ideal to the function called throw an `Exception` instead.. But I can see that something like package:http won't throw on 5xx responses, you if you want...
quick note: I wonder if we could call it `retryIfValue` instead of `retryIfReturnedObject` which rather long... Or maybe `retryOnReturnIf`, other good names?
`retryValueIf` might be solid..
I'm not actually sure what is correct :D