Jonas Finnemann Jensen

Assigned to you. This is mostly a bit of refactoring and making sure the public API is pretty, while also making sure people accessing it can't `implement` our classes :D

Might I suggest trying it out on something simple like `HmacSecretKey`, making a WIP (draft) PR, so that we can decide if we like that pattern before we apply the...

In particular you can avoid things like: https://github.com/dart-lang/dart_ci/blob/9e8bc64693bc56e939cfdd8d59b471505a189815/bin/server.dart#L49-L53 And simply write: ```dart class MyService { @Route.get('/log////') Future serveLog(shelf.Request request, String builder, String configuration, String build, String test) async { .......

Note the parameter validation: https://github.com/dart-lang/dart_ci/blob/e5ee9ef515df4650225caf6e334799707ac3c66f/lib/src/get_log.dart#L38-L45 Might also be something you could move into the router pattern...

Note, using package `logging` allows you to set severity, rather than just printing errors to stdout...

@eliasyishak, yeah, I don't see how this can happen. It might be possible to reproduce locally by hacking `/etc/hosts` such that `www.google-analytics.com` points to an IP that is unreachable. But...

Minor notes: Adding `includeTransitive` is breaking API change. I'd suggest we just leave it to the consumer to do a `.where((e) => e.isDirectDependency)`. No need to complicate the API with...

Importantly this might be hard because we don't have a mechanism for knowing what the current root package is. We can guess, which would probably work, until we implement workspaces....

We've discussed this a few times and with workspaces happening, maybe we need to consider something like: ```js { "configVersion": 2, "packages": [ { "name": "yaml", "rootUri": "file:///jonasfj/.pub-cache/hosted/pub.dev/yaml-3.1.2", "packageUri": "lib/",...

Years ago we had "features" in pub, but it was never really launched. It allowed a package to declare dependencies that would only be required, if the package depending on...