Jonas Finnemann Jensen
Jonas Finnemann Jensen
This appears to still happen from time to time. We just get a 12 min timeout. But I think #98 improved the situation.
Or try with ASAN or MSAN, but that requires a custom build of the Dart / Flutter SDK.
Yeah, adding `Future main() async {` around the actual statement-level code won't hurt readability.
Merged https://github.com/google/webcrypto.dart/pull/77 and closing this for now. If someone is interested in trying to figure out if this is an flaky, and/or what we could do to make it work...
I just landed https://github.com/google/webcrypto.dart/pull/78 and will publish. But I had to manually rerun the tests to get it to pass. * First time it timed out after 12 minutes. *...
See also: https://github.com/google/webcrypto.dart/issues/63
I think we should add the same thing to all private classes throughout the package. Like `RsaOaepPublicKey`, etc. they also have private implementations.
@devenderbutani21 Feel free to ping me `@jonasfj` for reviews, I'm happy to help merge PRs. I'm jonasfj88 on discord, see [`dart_commmunity`](https://dart.dev/community), @HamdaanAliQuatil and I are hanging out in a thread...
> imo providing the key with the hash function would be a pretty bad idea (option 1) over concerns of inspection at runtime by malicious actors. The hash function isn't...
I suspect the hard part with an isolate pool is to manage it's life-cycle without being forced to extend the public API for the package with methods to define this...