jonaro00

Results 82 comments of jonaro00

@Danielku15 Yes, however: The implementation as of now is mostly me just guessing. Since I'm not a guitarist, I'm not really sure what timings in the default behavior is reasonable....

@Danielku15 I looked in the gp7 test data files, they only include cases with quarter notes in tempo 120, with a resulting brushDuration of 60, which equals `playbackDuration / 16`...

@Danielku15 There wasn't much difference between dividing with 4 or 8. I took 4 based on preference. Wrote tests, should be ready for review now.

Turns out I don't have the correct dotnet SDK on my machine to verify... I made my best guess at what the breaking change was, so try running workflows again....

It should be working at this point. (yup, it did)

To clarify: Would the syntax be `(0.1 1.2 0.3 2.4 3.5){ch "C" bd 60}` for example?

I think I managed to (poorly) implement toThrowError in C#. Kotlin is a bit trickier. Would appreciate help on that one.

Thanks for the suggestion! Looks promising. We will investigate.

Closing in favour of #1559

Not planned at the moment due to cargo-generate not supporting rustls