alphaTab icon indicating copy to clipboard operation
alphaTab copied to clipboard

Add minor keys

Open jonaro00 opened this issue 2 years ago • 2 comments

Issues

Fixes #875

Proposed changes

Adds the ability to specify minor keys in alphaTab. Major keys can also be explicitly stated.

Checklist

  • [x] I consent that this change becomes part of alphaTab under it's current or any future open source license
  • [x] Changes are implemented
  • [x] Existing builds tests pass
  • [x] New tests were added

Further details

  • [ ] This is a breaking change
  • [x] This change will require update of the documentation/website

jonaro00 avatar May 25 '22 15:05 jonaro00

@jonaro00 C#/Kotlin builds are broken by this change.

Danielku15 avatar Jun 12 '22 11:06 Danielku15

I think I managed to (poorly) implement toThrowError in C#. Kotlin is a bit trickier. Would appreciate help on that one.

jonaro00 avatar Jun 13 '22 22:06 jonaro00

Adapted the missing bits on the C# and Kotlin code to make them happy on your new ToThrowError usage. Thanks for the contribution 😁

Danielku15 avatar Aug 27 '22 21:08 Danielku15