Jonathan Almeida
Jonathan Almeida
@jeffreygee @iorgamgabriel we should be using the colour for the Custom Tab that the app is requesting when provided. Based on the colour that is provided to the toolbar, the...
If we do want to force the theming however (to make Focus stand out), we should change the properties of the `CustomTabToolbarFeature` [here](https://github.com/mozilla-mobile/focus-android/blob/main/app/src/main/java/org/mozilla/focus/browser/integration/BrowserToolbarIntegration.kt#L158-L166) and set `updateToolbarBackground` to false and probably...
Thanks for the profiles. Comparing the 'after refactor + 97ms improvement' against the 'before refactor', I've left a short comparison: - About **+190ms** increased from the `BrowserToolbar` that was previous...
Some notes on possible next actions: > About +190ms increased from the BrowserToolbar that was previous only the InlineAutocompleteEditText. I think Fenix doesn't use the BrowserToolbar for the homescreen until...
Happy to help with testing if needed - ran into this bug as well. I have an Ontario certificate and the oldest vaccine is on the second page so it's...
> So I'd think we just need the application code to wire up what already exists in GV. The backing Presentation API in Gecko was removed since it wasn't supported...
Happened again in an unrelated PR: [logs link](https://pipelines.actions.githubusercontent.com/serviceHosts/76ef84e6-2541-41e9-85c1-758085b4811e/_apis/pipelines/1/runs/77230/signedlogcontent/8?urlExpires=2022-08-11T02%3A51%3A37.8968811Z&urlSigningMethod=HMACV1&urlSignature=Fx%2FD7x0CJ7rvm0Pno4fCioHleO1gy1orJhcVJVOfAwk%3D)
We updated to a new Glean version recently, that might be related.
I can reproduce this bug as well. The debugger shows a white screen because the tab process is crashing. I was able to attach a debugger before it crashed, but...
> @jonalmeida just a heads up: after your review and rebasing, I added this [commit](https://github.com/mozilla-mobile/fenix/pull/25991/commits/e56e09f240c48dc13364b662540947e1e0636df1) (so you can review it if needed). All good - feel free to still land...