Jonathan Almeida

Results 109 comments of Jonathan Almeida

> This will help decouple implementations from the specifics of requiring either a `Context` or a `SyncEnginesStorage` and will generally decrease reliance on needing to know the internals of various...

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1794233 Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).

Happened again: https://firefoxci.taskcluster-artifacts.net/cT5yBPb2QlyyBDljlFWcHw/0/public/logs/live_backing.log ``` [task 2022-06-15T11:47:05.571Z] TEST: close button invokes callback and removes session [task 2022-06-15T11:47:05.670Z] E/ThemeUtils: View class mozilla.components.browser.toolbar.display.TrackingProtectionIconView is an AppCompat widget that can only be used with...

Happened again: https://firefoxci.taskcluster-artifacts.net/Iik6uq9ARayY42muKrcZTg/0/public/logs/live_backing.log

> For my context: will Focus use GeckoView at all? (I ask because GeckoView+Glean has its own interesting megazording thing going on as well). Focus uses GeckoView exclusively. 🙂 I...

@jhugman and I spoke about this in relation to https://github.com/mozilla-mobile/focus-android/pull/5890. With Focus, being smaller/faster is part of the product image, so if we can reduce the size this would be...

A megazord is useful to de-duplicate native dependencies in our rust components. It would be useful to compare what is the file-size impact with and without a megazord before we...

We could use something like [avocado](https://github.com/alexjlockwood/avocado) to try and reduce the SVG files then validate that we aren't causing bug/glyphs in the icon when rendered.

Nice find and example code. 🙂

@Amejia481 @ohall-m updated the patch based on the review comments and added the appropriate tests.