John Ryan

Results 210 comments of John Ryan

I can't reproduce this. Please comment here if this is still happening.

Thank you @Vedanshi27vishu, please follow [these instructions](https://github.com/dart-lang/dart-pad/tree/main/pkgs/dart_services#modifying-supported-packages) to add a new package to DartPad

I took the liberty of re-writing this sample with my feedback applied, here's a zip containing the `lib` directory with the changes I would like to see: [lib.zip](https://github.com/user-attachments/files/16073021/lib.zip)

> every team I've been on has ended up implementing something exactly like this (but with an additional "loading" state as well) and it really cleans up how viewmodels can...

@reidbaker Is that something that _every_ developer needs to know and implement, or could this be a recommendation that we make separately? This seems like it's a useful technique, but...

FWIW I have never found a need to use these types of objects because I've found that I can model the `init`, `loading`, `loaded`, and `error` state transitions using async...

Those are good points, thanks for helping me understand the benefits. My only rebuttal would be that the developer still needs to handle errors (and has to deal with the...

That makes sense. Let's keep the Result class. I think our recommendation could be "Use the `Result` class for objects returned by the Model layer to the ViewModel layer, so...

Why is the code in the `compass_app/app` directory and not `compass_app/`?

Thanks for offering to help! We are still in the decision-making stage on these features. Have you tested the performance of this PR?