John Ryan

icon indicating a website link http://jpryan.me

icon company @google icon location Portland, OR

Results 210 comments of John Ryan

Firebase gist not displaying UI properly

This is probably out of date since we don't currently have Firebase support.

[go_router] Query Parameters are not preserved on `pop`

Thanks for filing an issue, this is something we should fix.

[go_router_builder] Creating a TypedGoRoute with non nullable queryParameter generates an invalid _fromState extension

Thanks for filing an issue, this seems like a bug we should fix.

[go_router_builder] Add ShellRoute support to go_router_builder

Yes, annotations must have a `const` constructor, so all of the fields must be final and all of the parameters must be const too. Since `Key`s in Flutter aren't const,...

[go_router_builder] Add ShellRoute support to go_router_builder

I'm trying to add an example for ShellRouteData, but I'm stuck because the `.g.dart` file isn't getting generated: ```dart // Copyright 2013 The Flutter Authors. All rights reserved. // Use...

[go_router_builder] Add ShellRoute support to go_router_builder

Sorry, this isn't ready to land yet. I'm currently busy with other projects, if someone else can work on this, feel free. The issue I mentioned in the comment above...

[go_router] [web] Refreshing on nested app loses current route (redirect to initialLocation route)

I can't reproduce this. When I run the sample using `flutter run -d chrome` I am able to navigate to `/page2` and refresh the browser, which will show `/page2` correctly....

Not able to navigate using tab key when using nested Navigators.

cc @craiglabenz

[go_router] ShellRoute, builder function gets called only when called by context.go() ,

Related to https://github.com/flutter/flutter/issues/100468

could not find package test_utils

The [test_utils](https://github.com/dart-lang/samples/tree/main/ffi/test_utils) package is used for testing the sample. There might be a better way to test the sample without causing confusion.