John Omotani

Results 74 comments of John Omotani

bump: please don't forget about this!

Hi, I ran into what I guess is a similar issue. I've started looking at threading, and hoped to make things as simple as possible. From the comment here https://github.com/JuliaLang/julia/issues/19777#issuecomment-492457370...

Thanks for the tips @Jutho , that helps a lot! I noticed that on 10 threads the 'by hand' `dostuff_threaded` is slightly faster than the strided or unsafe_strided versions (6.7ms...

:+1: thanks for the info! > probably there are already other packages which are much better at this. Sorry, I'm very new to Julia... if it's obvious what any of...

The vertical spacing around the controls is set when the sub-grids are created here https://github.com/t-makaro/animatplot/blob/df92ada79a39d2b250079fbe149c7ac8e0396af2/animatplot/animation.py#L109-L111 and here https://github.com/t-makaro/animatplot/blob/df92ada79a39d2b250079fbe149c7ac8e0396af2/animatplot/animation.py#L167-L169 I guess the problem is that `tight_layout` cannot change these numbers, but...

Setting the z-axis limits needed to use `ax.set_zlim()`, not `vmin` and `vmax` arguments (which only affect the color scale). Fixed now.

Tests and documentation added. I think this is ready for review/merge now.

> I would recommend to pip install zoidberg. Sounds good to me, but then maybe we should disable the test if zoidberg's not installed?

Note: if we change this, don't forget to update the docs in https://github.com/boutproject/BOUT-dev/blob/next/manual/sphinx/user_docs/variable_init.rst.

> Or to perhaps add it to the input file upgrader, setting it explicitly to `true` if it doesn't exist? This sounds ideal to me :+1: