BOUT-dev icon indicating copy to clipboard operation
BOUT-dev copied to clipboard

Missing zoidberg for FCI test on next

Open johnomotani opened this issue 2 years ago • 2 comments

I just tried to compile/test next (at 1707893f0f28525c310a2c82b836aafa71c87a44), and MMS-spatial-fci failed due to

Traceback (most recent call last):
  File ".../BOUT-dev/build/tests/MMS/spatial/fci/runtest", line 20, in <module>
    import zoidberg as zb
ModuleNotFoundError: No module named 'zoidberg'

I guess we should maybe: include zoidberg as a submodule like boutdata/boututils; test whether zoidberg is available, and make running MMS-spatial-fci conditional on it being found; something else?

johnomotani avatar Aug 23 '22 10:08 johnomotani

I would recommend to pip install zoidberg.

That would probably also make sense for the other python tools, but as that is used by more people, it might be harder to change ...

dschwoerer avatar Aug 23 '22 11:08 dschwoerer

I would recommend to pip install zoidberg.

Sounds good to me, but then maybe we should disable the test if zoidberg's not installed?

johnomotani avatar Aug 23 '22 11:08 johnomotani