John Letey

Results 23 comments of John Letey

> This seems a duplicate of an old issue, I cant find it atm but its essentially the same and never went anywhere. @the-j0k3r Ah okay, I couldn't find any...

As far as a suitable red colour goes, this site uses [Primer Colours](https://primer.style/css/support/color-system):

> Who needs to approve this? /cc @colebemis

@arjasco Unfortunately, that icon has fills in it - which is against the Feather icon guidelines. @krrohitch Well done 😍 Would love to see those icons add to @featherity 😉

> didn't see somebody had already done it @scodeler Take a look at #670. I (well on my old account that I've now lost access to) designed these. But I...

@frankphilip I really love that 😍 I have another suggestion as well: ![meter](https://user-images.githubusercontent.com/62398724/84889748-4a35ae80-b091-11ea-8dd9-2f22e6301491.png) ```svg ```

> would like to contribute a few more if given the chance Feel free! Also me and other members of the Feather community have gone off and started a community...

> also, maybe we should rename `proposal_cancel_burn_rate` to `proposal_cancel_rate`, wdyt? @robert-zaremba I would be in favour of `proposal_cancel_ratio` (so it's in line with `min_initial_deposit_ratio`).

In theory, the `runTx` function should also return any post-handler events, similar to how it returns the ante-handler events. I left it out of this PR as it's an API...

@tac0turtle, Where would be the best place to add a test? `types/handler_test.go`? Also, I just realised #13941, but after looking at it - looks like this problem still occurs.