feather icon indicating copy to clipboard operation
feather copied to clipboard

Icon request: QR Code

Open Aviortheking opened this issue 5 years ago â€ĸ 35 comments

Icon Request

  • Icon name: qr-code
  • Use case: show a qr3code on click
  • Screenshots of similar icons: font-awesome: https://fontawesome.com/icons/qrcode mdi: https://materialdesignicons.com/icon/qrcode-scan

Aviortheking avatar May 14 '19 14:05 Aviortheking

@colebemis @locness3 @Aviortheking How does this look?

jletey avatar Jun 23 '19 03:06 jletey

Have tyou made it by yourself ? BTW, please check you are conform with #171 .

moeenio avatar Jun 23 '19 07:06 moeenio

@locness3 I looked at the font-awesome design and then tried to use #171, although I'm not quite sure I did a good job ... but yes, I made it by myself.

jletey avatar Jun 23 '19 13:06 jletey

@locness3 I looked at the font-awesome design and then tried to use #171, although I'm not quite sure I did a good job ... but yes, I made it by myself.

Instead of doing what you're doing, use squares with 2px borders.

moeenio avatar Jun 23 '19 13:06 moeenio

@locness3 so no rounded edges ... but 2px borders?

jletey avatar Jun 23 '19 13:06 jletey

@locness3 so no rounded edges ... but 2px borders?

You should round edges with a 90degree angles (as states #171

moeenio avatar Jun 23 '19 13:06 moeenio

@locness3 I have updated the icon ... please take a look!

jletey avatar Jun 23 '19 13:06 jletey

You should round the bottom-right thing, and make it a compound path.

moeenio avatar Jun 23 '19 14:06 moeenio

More than just rounding them, you should make them strokes, no fills are allowed.

moeenio avatar Jun 23 '19 14:06 moeenio

@locness3 I have refactored with all of your changes ... unfortunately, it was really hard for me to get the two squares in the bottom-right thing to be apart of the rest of the vector for the bottom-right thing ... hopefully, this isn't a problem!

jletey avatar Jun 23 '19 18:06 jletey

@locness3 I have refactored with all of your changes ... unfortunately, it was really hard for me to get the two squares in the bottom-right thing to be apart of the rest of the vector for the bottom-right thing ... hopefully, this isn't a problem!

When you will have rounded the two squares at the bottom right, that will be perfect!

moeenio avatar Jun 24 '19 13:06 moeenio

@locness3 Not exactly quite sure how I'm supposed to round the square, as when I try to round them, they either change to nothing or a ring 😞 ... but, if I change the stroke width to 1px (which is clearly against #171), I get a perfectly rounded square!

jletey avatar Jun 25 '19 04:06 jletey

on Figma a single point with stroke isn't shown at all so don't worry about that

Aviortheking avatar Jun 25 '19 09:06 Aviortheking

@locness3 Not exactly quite sure how I'm supposed to round the square, as when I try to round them, they either change to nothing or a ring 😞 ... but, if I change the stroke width to 1px (which is clearly against #171), I get a perfectly rounded square!

Do a single path point with a stroke

moeenio avatar Jun 25 '19 16:06 moeenio

@locness3 How exactly do you do a "single path point with a stroke"?

jletey avatar Jun 25 '19 18:06 jletey

@locness3 How exactly do you do a "single path point with a stroke"?

Create one path point with your habitual pen tool I guess

moeenio avatar Jun 25 '19 18:06 moeenio

@locness3 Doesn't work ... when I try to do this, by creating a point with the pen tool, it doesn't show up even after I select different strokes

jletey avatar Jun 25 '19 18:06 jletey

@locness3 Doesn't work ... when I try to do this, by creating a point with the pen tool, it doesn't show up even after I select different strokes

Have you tried exporting it and oprening in a browser ?

moeenio avatar Jun 26 '19 05:06 moeenio

Have you tried exporting it and oprening in a browser ?

@locness3 Just did ... not showing up

jletey avatar Jun 26 '19 06:06 jletey

Have you tried exporting it and oprening in a browser ?

@locness3 Just did ... not showing up

🤔

moeenio avatar Jun 26 '19 11:06 moeenio

I'd like to suggest another design for the QR code icon: image

This is heavily influenced by several Indonesian digital wallet apps that bear similar icons: image image image

I decided to use a rounded square on the bottom-right corner to be distinguishable from others, so people may still be able to interpret this as a normal QR code.

You can have a look of the SVG file at https://drive.google.com/open?id=14nO2J2PaODXfcgmB7ZIc3SXf4RPHzXQZ

reinhart1010 avatar Feb 13 '20 03:02 reinhart1010

Idk, what do you think @johnletey ?

moeenio avatar Feb 16 '20 14:02 moeenio

@colebemis @locness3 @Aviortheking How does this look?

You've got the Font-Awesome flag in there, so no, I wouldn't do it like this.

JelleBlaauw avatar Jun 19 '20 09:06 JelleBlaauw

Would like to make a suggestion here - Figma link image

krrohitch avatar Jul 22 '20 05:07 krrohitch

@krrohitch To me, this is more "scan qr code" than "qr code".

moeenio avatar Jul 22 '20 06:07 moeenio

You have a point there. I'll try one without the outer frame. Meanwhile, this could be used as qr-scan if required.

krrohitch avatar Jul 22 '20 06:07 krrohitch

Made a quick iteration. What do you think @locness3 ? image

krrohitch avatar Jul 22 '20 07:07 krrohitch

I attempted something similar using the grid icon as the basis. Screenshot 2020-08-01 at 11 34 51

Would love a native QR code icon that matches the rest of the icon set please!

arjasco avatar Aug 01 '20 10:08 arjasco

@arjasco Unfortunately, that icon has fills in it - which is against the Feather icon guidelines.

@krrohitch Well done 😍 Would love to see those icons add to @featherity 😉

johnletey avatar Aug 01 '20 14:08 johnletey

@johnletey Understood! It wasn't meant to be a candidate for this icon, just a play on an idea before coming to this issue.

How could we see the icon @krrohitch has produced make it in? This repo seems like is really isn't getting much attention which is a shame because it's a great icon set.

Does the mentioned fork contain all the current icons? I'm currently creating an SVG map with a subset of the icons I require, annoyingly could really do with a QR code one ☚ī¸

arjasco avatar Aug 01 '20 15:08 arjasco