John Haitas

Results 8 comments of John Haitas

This should resolve https://github.com/developit/preact-render-to-string/issues/64

This current implementation is incorrect per this documentation: https://reactjs.org/docs/react-component.html#error-boundaries > **NOTE** > Error boundaries only catch errors in the components *below* them in the tree. An error boundary can’t catch...

I have updated the tests to verify that the error is in fact being passed to `componentDidCatch` with c7aba79.

per react's server support for error boundaries (https://github.com/developit/preact-render-to-string/pull/66/#issuecomment-464513856) ... if react does not support it, then it probably is not right to support it

This current implementation is incorrect per this documentation: https://reactjs.org/docs/react-component.html#error-boundaries > **NOTE** > Error boundaries only catch errors in the components *below* them in the tree. An error boundary can’t catch...

I have updated the tests to verify that the error is in fact being passed to `getDerivedStateFromError` with 03971f9 or `componentDidCatch` with c7aba79.

i'd say this is not a good idea if react does not support it