John Blackbourn comments

Results 496 comments of


                                            John Blackbourn

Symlink'd wp-contents folder gives no results

I'm going to close this off as this is nightmarish road that I don't want to go down.

Add new qm/collect/silent_http_error_statuses filter to silence specific HTTP API requests that result in 400-500 HTTP status codes

Closing as per #474

Update theme.php

Can you provide some information about why this change is needed?

Add type checking for hook callbacks in `add_action` and `add_filter`

This was only partially completed, I'll open a follow-up issue with the details.

Add type checking for hook callbacks in `add_action` and `add_filter`

@menno-ll Are you using version 1.1.5? Issues with `mixed` should have been fixed in that version. If so, can you open a new issue please? Regarding returning a value from...

Treat assertNotWPError() and assertWPError() as type-narrowing functions

Yes the idea is that any parameter passed to `assertNotWPError()` cannot be a `WP_Error` in subsequent lines. https://phpstan.org/writing-php-code/narrowing-types I tried phpstan-phpunit but it had no effect, but I didn't play...

Add type checking for hook callbacks in `add_action` and `add_filter`

I'm stuck on `isCallable()->yes()` not returning the expected value in some cases. Opened https://github.com/phpstan/phpstan/discussions/7715 to ask for help.

Add type checking for hook callbacks in `add_action` and `add_filter`

We're all green ✅ but I want to add some more tests in.

Add type checking for hook callbacks in `add_action` and `add_filter`

@szepeviktor @herndlm Would be great to get this in

Add type checking for hook callbacks in `add_action` and `add_filter`

Yeah might be related to #118 or #119 :(