johnb432

Results 140 comments of johnb432

I think it's due to [this](https://github.com/acemod/ACE3/blob/22586fc137aa434286f948f9226336e9587d6c6f/addons/arsenal/functions/fnc_buttonImport.sqf#L32) not accommodating for CBA extended loadouts. I have a PR coming soon that *should* address this amongst things.

> Current implementation reports config case of the items. What case does this return? All lower? Config? Whatever is listed inside `compatibleItems`, regardless of if that is the capitalization of...

Dedmen was able to confirm that both `compatibleMagazines` and `compatibleItems` return config sensitive strings.

> Someone who knows how to set up a config with broken case should test that. Otherwise, this PR may silently break a ton of stuff in ACE and other...

Well.. I managed to break `CBA_fnc_compatibleItems` with a broken config (well, it depends on what you consider breaking). I used the following config and packed it into a PBO: ```cpp...

> seems like we could use the alt syntax to do the filtering as well? > > ``` > params [["_weapon", "", [""]], ["_typefilter", nil, ["", 0]]]; > > if...

> ```c++ > class CfgMagazines { > class RPG32_F; > class CBA_TestMagazine: RPG32_F {}; > }; > > class CfgWeapons { > class CBA_MiscItem; > class CBA_MiscItem_ItemInfo; > > class...

When running (the proposed changed one) ```SQF "CBA_TestLauncher" call CBA_fnc_compatibleItems ``` it throws errors: - a popup one, if you haven't had any previous popups - in the RPT: ```...

My project was to improve `CBA_fnc_compatibleItems`' performance by using `compatibleItems`. However, it doesn't seem to be the right way forward. For me, there are other ways that `CBA_fnc_compatibleItems` can be...

> See: [#1558 (comment)](https://github.com/CBATeam/CBA_A3/pull/1558#issuecomment-1249703466) Would this PR be accepted, if `compatibleMagazines` would be reverted back to `CBA_fnc_compatibleMagazines`?