johnataylor

[* Number] Percentage recognizer resolution should resolve to fraction

2

Recognizing an utterance such as 'fifty percent' as a percentage value is great but it would be more helpful to client code if the resolution was to a floating point...

cleanup samples folders

1

The code-first Adaptive Dialog samples folder https://github.com/microsoft/BotBuilder-Samples/tree/main/samples/csharp_dotnetcore/adaptive-dialog causes confusion and should be dropped. We are not suggesting hand crafting Adaptive Dialogs in code is a reasonable development approach. The experimental...

20>C:\private\v4\scratch\BotBuilder-Samples\samples\csharp_dotnetcore\45.state-management\StateMangementBot.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible...

SetSpeakMiddleware uses string formatting to create XML

1

Code in the SetSpeakMiddleware uses raw string formatting to create XML and is therefore exposed to badly formed XML creation, for example, if the values in the data contained characters...

LG fromFile should be implemented against the resource provider framework

Proactive C# sample needs to stop sending mock appId

1

The current proactive sample in C# sends a mock appId (its actually a new GUID) This only ever worked because we had a check in the AppCredentials implementation that looked...

Tokenizer in Choice Prompt fails on some characters

2

The Tokenizer attempts to split input that includes emojis. This code works for the basic emoji characters (thumbs up, down, smile etc.) but fails on the multi-character emojis that include...

Language Generation uses Adaptive Expressions that can be extended with custom functions. This is illustrated by this sample https://github.com/microsoft/BotBuilder-Samples/tree/master/samples/csharp_dotnetcore/language-generation/20.extending-with-custom-functions However, such functions cannot be async. "This is actually by design...