botbuilder-dotnet icon indicating copy to clipboard operation
botbuilder-dotnet copied to clipboard

SetSpeakMiddleware uses string formatting to create XML

Open johnataylor opened this issue 4 years ago • 1 comments

Code in the SetSpeakMiddleware uses raw string formatting to create XML and is therefore exposed to badly formed XML creation, for example, if the values in the data contained characters such as < or > or &;

Code that creates XML should always use System.Xml and System.Xml.Linq classes such as XDocument, XElement etc. to manipulate and construct XML.

johnataylor avatar Jul 19 '21 18:07 johnataylor

investigating

ram-xv avatar Apr 27 '22 17:04 ram-xv