John Stilley
John Stilley
As long as the docs still build, I'm sure this is fine. I _thought_ the docs didn't build with this dependency added. But maybe it was the `conf.py` links to...
This does not seem to change the error messages being thrown by the ARMI HTML docs build. For instance, both log files have this error: ``` /home/runner/work/armi/armi/armi/__init__.py:docstring of armi:1: ERROR:...
@drewj-usnctech I wanted to check that this change won't affect you. I can't imagine it will, but just to be sure.
I am working through this Issue. It will _seem_ random and unrelated, but it's not; I just found a bug in how hex corners-up grids calculate their grid offsets: https://github.com/terrapower/armi/blob/571e4f58f364229b754f11b56d10ef2c153b92c9/armi/utils/asciimaps.py#L611-L615...
Progress Update: I fixed `changePitch()`. It _was_ indeed broken. Here is my little drawing that our original unitSteps were correct:  @drewj-usnctech I know you suggested using new subclasses of...
@drewj-usnctech I believe the `HexGrid._getSymmetricIdenticalsThird()` method is already correct, and does not need any changes. It currently provides the same solution for "flats up" and "corners up" grids: https://github.com/terrapower/armi/blob/571e4f58f364229b754f11b56d10ef2c153b92c9/armi/reactor/grids/hexagonal.py#L379 But...
By the way, if anyone wants a good plot of the "flats up" vs "corners up" hex grids, here they are (thanks @ntouran ): I may try to highlight this...
@ntouran @keckler I was looking at the `HexGrid.overlapsWhichSymmetryLine()` method, it does the same thing for "corners up" and "flats up" hex grids. Here is what it identifies as the symmetry...
@drewj-usnctech In response to your original concern: > As I read it, the non-fuel pin should be in the top left of the hexagonal grid. But, the locator attached to...
Okay, the problem here is clearly that this is not how we calculate mass: ```python a[0][0].getVolume() * a[0][0].material.density(Tc=25+dT) ``` We calculate mass starting at the number densities of each nuclide:...