John Stilley

Results 306 comments of John Stilley

I still haven't resolved the "60-degree rotation" of the hex grid stated in the original comment: https://github.com/terrapower/armi/issues/1278#issuecomment-1959940388 Mind you, that original ticket had 6 major complaints, and I sorted 5...

I have verified this PR does not break any downstream unit tests (I mean, at least any downstream unit tests I can find).

I'm not ignoring this, I am just very busy with an approaching deadline.

I have opened an alternate PR to this here: https://github.com/terrapower/armi/pull/1664

Yeah, I agree with the jist of this ticket. I think perhaps someone was so excited about adding as much functionality as possible, we have helper methods on classes that...

Here is some research on the methods I find most suspect: ## ArmiObject | Method | ARMI Usages | Downstream Usages | Types Called On | Keep? | | -----...

@ntouran @albeanth @drewj-usnctech @sombrereau @keckler I have given two options above. Which do YOU think is true? (If no one votes, I will just decide.)

> We don't explicitly list out cross section data in our docs, I don't see any reason why half life data should be any different. > > My vote is...

Votes thus far: * **Option 1, remove the table:** 1. John 2. Chris 3. Nick * **Option 2, move it to somewhere else in the docs:** 1. Tony 2. Jake

I'm just thinking aloud here, but what something "flat-to-flat" be better for hex grids? Isn't the goal to call out that we are going to be explicitly picking one over...