Joseph Heenan

git gui crashes since upgrading to macOS Big Sur, after outputting "macOS 11 or later required !" The Wish binary is aborting, the call stack is: ``` 2 libsystem_c.dylib 0x00007fff20296720...

Xcode warns about these as they describe parameters that don't exist; add spaces (as done in other \param lines) between the parameter name and the [in] / [out]. Also correct...

"Presentation" is capitalised as if it's a defined term, but I can't find a definition

4

There are various sentences like: > When Key Binding is not enforced, any entity in possession of an SD-JWT Presentation can forward the contents to third parties where presentation has...

Rework iso mdoc/mdl section

6

We should do something with the ISO mdoc section of VCI; it's not clear about various things - e.g. what exact CBOR object should be returned in the credential response....

4.1.3 examples are non consistent

1

Feedback from George Fletcher: In 4.1.3 the credential offer examples are not self consistent: ``` GET /credential_offer HTTP/1.1 Host: server.example.com ``` ``` openid-credential-offer://? credential_offer_uri=https%3A%2F%2Fserver%2Eexample%2Ecom%2Fcredential-offer.json ```` One has the .json suffix,...

cryptographic_binding_methods_supported feels under described

2

`cryptographic_binding_methods_supported` feels like it's probably a bit under defined. https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#section-11.2.3 says: > cryptographic_binding_methods_supported: OPTIONAL. Array of case sensitive strings that identify the representation of the cryptographic key material that the...

Wallet can't always identity whether key proof is required

12

https://github.com/openid/OpenID4VCI/pull/87 added a mechanism within `credentials_configurations_supported` for the wallet to know if the issuer requires proof of possession for a particular credential configuration, and if so what types are supported....

benefits of attestation based client auth draft seem to be overstated

4

https://github.com/openid/OpenID4VCI/blob/main/openid-4-verifiable-credential-issuance-1_0.md?plain=1#L1335 currently says: > Note: For the attacker to be able to present to the Verifier a Credential bound to a replayed Key Proof, the attacker also needs to obtain...

Wallet should not return credentials where the signature has expired

1

Vaguely related to #159, as discussed on yesterday's WG call, we should probably clarify whether the wallet should return credentials that are expired and could no longer be validated. For...

redirect_uri client_id_scheme: is response_uri optional?

5

When using `client_id_scheme=redirect_uri`, you can omit redirect uri as per https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#client_metadata_management : > the Verifier MAY omit the redirect_uri Authorization Request parameter It would be logical to assume that when...