Joe Wallwork
Joe Wallwork
Ah okay thanks @jatkinson1000, I'd missed that discussion thread.
Closed as completed by #187 and others.
Hm so this implies we need to build the tests separately from FTorch? Doable but means we have two build steps. Either that or perhaps we can use `POST_BUILD`. I...
> I could cat it to a script that users run, or could just make building FTorch part of the setup so that it's ready to use on load. Any...
> @jwallwork23 shellcheck requested I do a few things to appease it that I am not really sure we want in a script that users are looking at (cd ||...
## Review checklist for @jwallwork23 ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
> 👋 @jwallwork23, please update us on how your review is going (this is an automated reminder). Made a start but still quite a bit to do. I should have...
> A useful thing to note is that if we want to set values of a tensor (e.g. loss, or a gradient) it must NOT have `requires_grad=.true.` or it will...
FYI I rebased this branch on top of `main` on branch [`joe/optim`](https://github.com/Cambridge-ICCS/FTorch/tree/joe/optim) in case it's useful. Really cool functionality!
> @jwallwork23 Take a look at [e59fa97](https://github.com/Cambridge-ICCS/FTorch/commit/e59fa97ad8436b952af7814ccdd7782f45a6affb) for updated unit tests for zero_grad. > > Note that in libtorch zero_grad does not set gradients to `0.0` but rather makes them...