Joe Wallwork
Joe Wallwork
[Rebased on top of main to bring in linting changes]
Thanks for the tips @TomMelt - with a few tweaks the tests now pass on Ubuntu. There's a build fail in the Windows CI, although I didn't edit the Windows...
> Thanks for the tips @TomMelt - with a few tweaks the tests now pass on Ubuntu. There's a build fail in the Windows CI, although I didn't edit the...
Merged in the Windows fix from #207 in https://github.com/Cambridge-ICCS/FTorch/pull/76/commits/23ce977bfa9068797a4f9be0ea183f6290e2f54a. Turned off unit testing for Windows in https://github.com/Cambridge-ICCS/FTorch/pull/76/commits/f1e9add826c8b02f87e6d53f1380d7d7b55f3521.
@dorchard I can't add you as a reviewer because you authored the initial commits, but any comments you have would be appreciated.
Went through this in the meeting today; up-to-date with `main` and ready for review.
> I'm having issues building the unit tests, e.g.: > > ``` > [ 37%] Building Fortran object test/unit/CMakeFiles/test_constructors.dir/test_constructors.F90.o > /Users/dorchard/Documents/iccs/FTorch/src/build/test/unit/test_constructors.F90:10:7: > > 10 | use pFUnit > | 1...
Note that I've opened #216 to fix a related issue with `torch_tensor_from_array`. It will merge into this PR.
> I think this is a good starting point for our unit tests. I had one suggestion. Having a 3D test would also be good I think, at least on...
Thanks again everyone! Merging now :rocket: