Joe Wallwork
Joe Wallwork
Closing as superseded by #276.
That didn't turn out to be too difficult. A few notes: 1. Couldn't figure out how to get the Python scripts under CTest without making them executable - hopefully not...
@jatkinson1000 @dorchard Okay, I think I addressed the requests above. If FTorch is built with `-DCMAKE_BUILD_TESTS=TRUE` then the examples get build as integration tests in `src/test/examples`. The tests can then...
> At the first invocation of `cmake` build I get a warning that it cannot find FTorch (obviously) for the exercises. Is there any way to suppress this at all?...
> It was not immediately clear that I need to go into `./test/examples/examplename/` to invoke ctest. This also feels a bit clunky. I wonder if we could use a shell-script...
> Finally, I think there is an element of 'works on my machine' as the regex didn't match on mine causing the tests to fail. Hopefully this can be easily...
Okay @jatkinson1000, I added a `pages/testing.md` page as requested and linked it in elsewhere. There's a comment above on two new warnings that haven't been addressed. Perhaps we could raise...
Thanks very much for your review @jatkinson1000! Will merge now.
Perhaps this PR could just set up the infrastructure and add tests for the tensor constructors and we could address writing unit tests for the rest of FTorch in a...
Interestingly, I needed to set the integer kind to get these tests working on my Ubuntu laptop, too (see https://github.com/Cambridge-ICCS/FTorch/pull/76/commits/c30bc218440d641e52ead288abbf4dc5e13c9a93). I'll update this to follow @TomMelt's 32-bit int approach once...