Johannes Theiner

Results 738 comments of Johannes Theiner

[MyPluginSettings](https://github.com/Azeirah/scrybble/blob/15ff2de8ac01dbf75c5d624fe5bad9692eac541c/main.ts#L6), [MyPlugin](https://github.com/Azeirah/scrybble/blob/15ff2de8ac01dbf75c5d624fe5bad9692eac541c/main.ts#L16), [SampleSettingTab](https://github.com/Azeirah/scrybble/blob/15ff2de8ac01dbf75c5d624fe5bad9692eac541c/main.ts#L101) You probably want to rename these. I don't know what one could do with the access token to your service, saving it in the plugin settings object...

[MyPlugin](https://github.com/Stardusten/ob-table-enhancer/blob/3ee82f5381efdf6f6436b46b59cb07b63f9ceb26/main.ts#L23) Please rename this class to something more meaningful. [// 劫持滚动事件](https://github.com/Stardusten/ob-table-enhancer/blob/3ee82f5381efdf6f6436b46b59cb07b63f9ceb26/main.ts#L55-L67) This will only work for the editor instance that was loaded at start and will completely block scrolling. [export...

Hi, we currently don't feel comfortable merging this in its current state. The DOM hacks you do are to unstable to have a stable plugin in the long term. From...

Please rename your plugin, Publish is already the name of our official offering: Even if we were to allow it, the plugin name does not make sense, it does not...

Quick note, to not break old links elsewhere on the web, you can put the old name in the frontmatter as an alias. They will automatically be used as redirects.

This plugin does not work at all on Android. See the README and #8

No, we can't (I am also part of that team) The issue is with Android itself, see the link the README.

that is od, I am already checking for that. Do you click any specific text, or just an empty area? Do you use the new live preview or the old...

Could you check in the developer console(`Ctrl/Cmd+Shift+I`) what gets printed when you click that link? As I don't have access to insider builds I need that output to make sure...

I have just added a check for the new editor, I hope I got the correct one.