obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

submit obsidian-publish-plugin to list

Open addozhang opened this issue 1 year ago • 2 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/addozhang/obsidian-publish-plugin

Release Checklist

  • [x] I have tested the plugin on
    • [ ] Windows
    • [x] macOS
    • [ ] Linux
    • [ ] Android (if applicable)
    • [ ] iOS (if applicable)
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
    • [ ] styles.css (optional)
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

addozhang avatar Sep 11 '22 11:09 addozhang

Hello addozhang!

I found the following errors in your plugin, Publish:

:x: Unable to find a release with the tag "0.1.0". Make sure that the manifest.json file in your repo points to the correct Github Release

Log
HttpError: Not Found

This check was done automatically.

github-actions[bot] avatar Sep 11 '22 11:09 github-actions[bot]

0.1.0 released.

addozhang avatar Sep 11 '22 11:09 addozhang

Please rename your plugin, Publish is already the name of our official offering: https://obsidian.md/publish Even if we were to allow it, the plugin name does not make sense, it does not publish anything on its own.

You can also remove obsidian from the plugin ID, it's unnecessary.

this.addStatusBarItem().setText("Status Bar Text"); Remove this

await fetch This should be replaced with Obsidians requestUrl function.

import {existsSync} from "fs"; This will only work on desktop, please mark your plugin as such.

!existsSync(join Don't use NodeJS API's for that, Obsidian provides its own: exists

See also: https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md#nodejs-and-electron-api

joethei avatar Sep 28 '22 06:09 joethei

Hi, this is the repo for the help documentation of Obsidian, not Obsidian itself.

If you have any feedback about Obsidian, please go to https://forum.obsidian.md instead, thanks!

ericaxu avatar Nov 09 '22 02:11 ericaxu