Joel Drapper comments

Results 170 comments of


                                            Joel Drapper

ArgumentError when rendering a partial from a `Phlex::Rails::Layout`

This is fixed in `main` and `v1`. It will be in the next release.

Change behavior of render "foo" to render a string instead of a Rails template

@bradgessler any thoughts on what we can do about this for 2.0? 🤔

Change behavior of render "foo" to render a string instead of a Rails template

Agh, this is such a tricky issue. None of those options feel quite right, but we have to come up with something. 🤔

Document variables

+1!

Markdown

I see. I thought that block was for the code block. Though I guess code blocks could be defined with markdown syntax.

Please integrate with GitLab.com

AttributesProxy

Yeah, that's what this is for.

Starting over

Thanks @hangsu! ❤️ `Literal::Decorator` makes sense to include with this. 👍 I want to get this fully documented with 100% code coverage before moving on to other stuff. Some of...

Allow attribute definition in any order

This will be fixed in #83, which is almost ready.

`Literal::Some` and `Literal::Nothing` should implement `#value_or_raise!` and deprecate `value`

The problem is we need to keep the `value` method around for internal unsafe comparisons. It should probably just be renamed to `__value__`.