Joel Drapper

Results 164 comments of Joel Drapper

I’m closing this as there have been quite a few changes to attributes since it was opened. Probably best to use this as a reference in a new take.

I think it would mainly be used from inside the `view_template` method. ```ruby def view_template vanish do render SomeComponent.new end end ``` Essentially all we need to do is rename...

I think it would be reasonable for vanish to take either: a _renderable_ as the first positional argument, e.g. ```ruby vanish MyComponent.new ``` or a block, e.g. ```ruby vanish do...

Neither would work form a controller. The only time Phlex supplements controllers is when you include `Phlex::Rails::Streaming`.

From what I’m hearing, it seems like you really need lower-level hooks into Phlex’ renderable interface so you can have custom form objects that are renderable in specific ways. I...

I like `element` or `tag`. We call these elements in the `register_element` method, and "tag" should include things like comments and doctypes, which this probably shouldn't include. I don’t think...

My vote is `tag` for all elements apart from `script` and then `unsafe_tag` for all elements including script tags. We could also include `comment` and `doctype`.

@willcosgrove looks like you added the label `breaking`, but I’m pretty sure this won't be a breaking change. Have I missed anything?

Implementation with a TracePoint.

We could ship a 1.x version that doesn't break.